-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds an example using PolygonLayer #351
Conversation
I'd love to add an image or a gif to show the result at the end of the notebook. Any preferred way to do that? Something like that |
You can put an image into the |
I'd forgotten that I hadn't given this a full review (feel free to ping me if I haven't reviewed in a day or two), though it would be great to have a screenshot for this as well. Since it's docs only, this can be merged after the release |
okay! Moving this out of draft |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good! Just a few comments
Hmm... One comment I have here is that I noticed that rendering the entire global map seems to affect the rendering of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice notebook example, Matt. Especially if you can distinguish shape colors by country code. 👍🏽
Added a short example notebook using the PolygonLayer together to create a map of municipal boundaries.
TODO: I'll need to add images and/or gifs to make the example more visually appealing.