Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tooltip rendering when not hovering over an object #215

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix tooltip rendering when not hovering over an object #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/tooltip/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,17 @@ function toHtmlTable(featureProperties: Record<string, any>): string {

export function getTooltip({ object }: GeoArrowPickingInfo): TooltipContent {
if (object) {
// If the row index is -1, return
// If the row index is -1 or undefined, return
//
// Note that this is a private API, but this appears to be the only way to
// get this information
if (object[rowIndexSymbol] && object[rowIndexSymbol] < 0) {
//
// Without this block, we end up showing a tooltip even when not hovering
// over a point
if (
!object[rowIndexSymbol] ||
(object[rowIndexSymbol] && object[rowIndexSymbol] < 0)
) {
return null;
}

Expand Down