Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move accessor length validation to serialization step #329

Closed
kylebarron opened this issue Jan 26, 2024 · 0 comments · Fixed by #333
Closed

Move accessor length validation to serialization step #329

kylebarron opened this issue Jan 26, 2024 · 0 comments · Fixed by #333

Comments

@kylebarron
Copy link
Member

Currently we validate accessor length in _validate_accessor_length on the layer itself, but that's probably not able to dynamically validate all accessors, even those added by an extension. Instead, we can check during serialization that the length of the column is the same as the length of the table.
@kylebarron kylebarron mentioned this issue Jan 26, 2024
Merged
kylebarron added a commit that referenced this issue Jan 26, 2024
@kylebarron
Move accessor length validation to serialization (#333)
de30e82 
Closes #329

Currently we validate accessor length in `_validate_accessor_length` on
the layer itself, but that's probably not able to dynamically validate
all accessors, even those added by an extension. Instead, we can check
during serialization that the length of the column is the same as the
length of the table.

This additionally adds a test that accessor length validation is checked
for extension accessors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move accessor length validation to serialization developmentseed/lonboard
1 participant
@kylebarron