Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a basic makefile #162

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add a basic makefile #162

merged 1 commit into from
Oct 31, 2024

Conversation

pantierra
Copy link
Contributor

@pantierra pantierra commented Oct 31, 2024 •
edited
Loading

Just to:

  • automate the installation steps
  • include a command for complete spin-up with minikube
  • simplify the documentation a bit
  • prepare for more commands (like ingestion, and more)

@pantierra pantierra force-pushed the feature/makefile branch 13 times, most recently from b6c4561 to 6e20b36 Compare October 31, 2024 14:19
ciaransweet
ciaransweet requested changes Oct 31, 2024
View reviewed changes
@pantierra pantierra force-pushed the feature/makefile branch 2 times, most recently from 70ef577 to c0d34bb Compare October 31, 2024 14:54
@pantierra
Copy link
Contributor Author

Many thanks for the review and suggestions, @ciaransweet!

ciaransweet
ciaransweet requested changes Oct 31, 2024
View reviewed changes
ciaransweet
ciaransweet approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ciaransweet ciaransweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Didn't test the cloud example but it worked on Minikube which tests the full thing anyway 🎉

@pantierra pantierra merged commit a4955ff into main Oct 31, 2024
3 checks passed
@pantierra pantierra deleted the feature/makefile branch October 31, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciaransweet ciaransweet ciaransweet approved these changes

@ividito ividito Awaiting requested review from ividito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pantierra @ciaransweet