Patches for incorrect headings parsing and fence code blocks not recognizing language class #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings surrounded by `~~` will be printed using `<s></s>` tags like referenced in [MDN docs](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s)
Add Strikethrough support
Token[14] is limited to 3 `###`, while headings can range from 1 `#` to 6 `######`. This limit leads to incorrect heading tags after 4 `####`. This change corrects current bug : token[14] should accept between 1 to 6 `######`.
# Headings levels patch
When `language-code` is given to fenced code block, we should allow zero or more spaces between fences and `language`. Like this: ``` ```js ``` or ``` js ``` ```
|
@Jonarod is |
|
Yeah it's not commonmark: it's more of a GFM flavoured thing. but for the cost... I thought it'd be useful :) |
|
Looks like 12 bytes. I might take a stab at golfing it down a bit, but I agree this is a useful addition (and backwards-compatible). |
|
There's something unstable in that PR that prevent a merge? |
developit
approved these changes
Apr 13, 2018
|
I think switching to Microbundle made room for this! |
developit
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headings
Token[14] is limited to 3
###, while headings can range from 1#to 6######.This limit leads to incorrect heading tags after 4
####.This change corrects current bug : token[14] should accept between 1 to 6
######.Fence code blocks
When
language-codeis given to fence code block, we should allow zero or more spaces between fences and thelanguageinput, like this :