Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Support booleans in minify options #858

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Fix: Support booleans in minify options #858

merged 4 commits into from
Jun 28, 2021

Conversation

marcbouchenoire
Copy link
Contributor

Context: Disabling Terser's mangling completely is only possible by setting mangle to false, but currently Microbundle replaces any non-object mangle option by {}.

This PR adds a special condition to allow the minify options compress and mangle to be set as booleans.

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2021

🦋 Changeset detected

Latest commit: b857c4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
microbundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, and I have been wanting this feature for a while. Perfect PR!

@developit developit merged commit b1a6374 into developit:master Jun 28, 2021
@preact-bot preact-bot mentioned this pull request Jun 28, 2021
@marcbouchenoire marcbouchenoire deleted the minify-options-boolean branch June 28, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants