Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hongbusi
requested review from
a team,
RainyNight9,
Hongbusi,
alexzhang1030,
architectMymine,
chenfan0,
jersonwei,
jp-liu,
kongcodes,
likui628,
xiuxiuyifan and
zgsgs
and removed request for
a team
|
在描述中关联一下对应的 issue，格式： |
|
fix done |
|
这个看看动态菜单合不合并，如果动态菜单没问题需要合并的话，你这里的 route 和菜单需要改一下🥺 |
|
对，这个先不要合并，如果动态菜单那个 合并完了，这个需要重新在更改一下 |
Hongbusi
reviewed
Apr 27, 2022
src/views/page/inline/index.vue
Outdated
| height: 100%; | ||
| } | ||
| } | ||
| </style> |
src/router/routes/modules/page.ts
Outdated
| path: 'inline', | ||
| name: 'inline', | ||
| component: () => import('~/views/page/inline/index.vue'), | ||
| props: true | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
可以新增一个 views/docs 目录来做文档页面，page 一开始的目的是存放错误页面，后续可能会改动。
✅ Deploy Preview for vue-hbs-admin ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@alexzhang1030 需要你来 review 一下，看看导航需要怎么修改～ |
待会看一下 |
6 tasks
|
@wang01h2 你这样不行，不是你的 pr 的代码直接粗暴同步对于 review 很不利，不如你就重开一个 pr？ |
Hongbusi
reviewed
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).Views
add inline page
Route
add inline route
close #50