Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates build.ps1 with ArgumentCompleter attribute on Task parameter #28

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

webtroter
Copy link
Contributor

This adds autocomplete to the Task parameter.

Description

The ArgumentCompleter attribute works by reading the psakefile.ps1 with Get-PSakeScriptTasks and providing autocomplete suggestions.

Related Issue

Discussion #25

Motivation and Context

Helps Task discovery

How Has This Been Tested?

Works on my machine, and seems simple enough

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@webtroter
Copy link
Contributor Author

I think I don't have tests to add since the change is part of the template. Is that correct?

@devblackops devblackops self-assigned this Sep 16, 2022
@devblackops devblackops added the enhancement New feature or request label Sep 16, 2022
@devblackops
Copy link
Owner

Thanks for the contribution @webtroter! This is a good addition.

@devblackops devblackops merged commit 21bce8c into devblackops:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants