-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SINGLE and PROMPT parameters. #92
Conversation
great addition @foonix We had some troubles with latest travis tests. We fixed those in our latest master. Could you rebase your branch please? |
e356e20
to
3a71caa
Compare
Done, thanks! |
@@ -21,14 +21,14 @@ SETCOLOR_WARNING="echo -en \\033[0;33m" | |||
# terminal sequence to reset to the default color. | |||
SETCOLOR_NORMAL="echo -en \\033[0;39m" | |||
# Set to anything other than 'no' to allow hotkey interactive startup... | |||
PROMPT=yes | |||
PROMPT=<%= @prompt ? 'yes' : 'no' %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you changed the default from yes to no, is that intentional?
The CIS recommendations for server hardening are to set |
@foonix I would like to make this a two step approach. First, add the flexibility, Second activate it. I'd like to ensure that we change behavior with the required version bump. Does that make any sense? |
Thanks for the feedback. Done and done. |
@foonix Great work. Thank you very much! |
Add SINGLE and PROMPT parameters.
remove old slack notification
Changing settings for SINGLE and PROMPT is required for CIS 1.5.4 - 1.5.5. This PR enables these to be set and sets the recommended settings by default.