Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SUID/SGID bit cleaning API spelling #72

Merged
merged 3 commits into from
Jan 28, 2015
Merged

fix SUID/SGID bit cleaning API spelling #72

merged 3 commits into from
Jan 28, 2015

Conversation

dupuy
Copy link
Contributor

@dupuy dupuy commented Jan 28, 2015

Having a misspelling in an API is especially awkward, since fixing the spelling could break the code. But I think this is obscure enough that nobody is likely to be using it already...

@chris-rock
Copy link
Member

thanks @dupuy for pointing this out!

@chris-rock
Copy link
Member

@dupuy to make it complete, it would be great if you could fix it in https://github.com/TelekomLabs/chef-os-hardening/blob/master/TUTORIAL.md as well

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 609f726 on dupuy:api-typo into 27271de on TelekomLabs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 609f726 on dupuy:api-typo into 27271de on TelekomLabs:master.

@dupuy
Copy link
Contributor Author

dupuy commented Jan 28, 2015

OK, I (re?)added the typo fix to TUTORIAL.md, and fixed a rubocop alignment error I introduced when I wrapped a long line - with the additional 2 commits, it is satisfying Travis and Coveralls.

@chris-rock
Copy link
Member

@dupuy great work!

chris-rock added a commit that referenced this pull request Jan 28, 2015
fix SUID/SGID bit cleaning API spelling (unkown -> unknown)
@chris-rock chris-rock merged commit eb49def into dev-sec:master Jan 28, 2015
@dupuy dupuy deleted the api-typo branch March 18, 2015 13:22
rollbrettler pushed a commit to rollbrettler/chef-os-hardening that referenced this pull request Sep 16, 2016
add privilege separation via sandbox mode for ssh >= 5.9
@schurzi schurzi changed the title fix SUID/SGID bit cleaning API spelling (unkown -> unknown) fix SUID/SGID bit cleaning API spelling May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants