Idempotency #64
Merged
Idempotency #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @rmoriz sounds like great idea. Are you describing https://github.com/TelekomLabs/chef-os-hardening/blob/master/recipes/minimize_access.rb#L26 ? Anything else? You mentioned various resources? |
|
Chef marks "changes" in green, so here's just a dump of an example converge. (same thing with the ssh-hardning cockbook) |
|
@rmoriz we schedule this improvement for our next release this year... |
TelekomLabs-DCO-1.1-Signed-off-by: Edmund Haselwanter <[email protected]> (github: ehaselwanter)
TelekomLabs-DCO-1.1-Signed-off-by: Edmund Haselwanter <[email protected]> (github: ehaselwanter)
|
@ehaselwanter amazing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various resources get executed even if there is no change needed. While this is fine it 'pollutes' chef's statistics about updated resources e.g. when someone is monitoring those data using a chef-handler will see changes/updates on each converge:
e.g. within
https://github.com/TelekomLabs/chef-os-hardening/blob/master/recipes/minimize_access.rb
I would probably split "group" and "other" into separate resources and guard them by "only_if" filters using "find #{folder} -perm -g+w " and "find #{folder} -perm -o+w "