-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes made to make os_hardening compatible with immutable filesystem (atomic-container) #666
Conversation
…m of rpm-ostree system. Introduced new default var os_immutable_fs which defaults to ansible_facts.pkg_mgr not 'atomic_container'. Prevented ansible.builtin.packages and yum etc from installing or removing files on atomic_container systems, due to requirement to reboot and to use community.general.rpm_ostree instead of ansible.builtin.packages Signed-off-by: James Miller <[email protected]>
…ng ostree systems Signed-off-by: James Miller <[email protected]>
CI is currently failing because of: ansible/molecule#3883 |
I updated our testing, can you please update your PR? |
@schurzi I have managed to get in a mess by leaving the 'signed-off by' out of the commit message, and I just don't have time to fully comprehend the git rebase process at the moment. I have tried updating the commit messages several times, but it doesn't seem to change anything viz the checks. |
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
…m of rpm-ostree system. Introduced new default var os_immutable_fs which defaults to ansible_facts.pkg_mgr not 'atomic_container'. Prevented ansible.builtin.packages and yum etc from installing or removing files on atomic_container systems, due to requirement to reboot and to use community.general.rpm_ostree instead of ansible.builtin.packages Signed-off-by: James Miller <[email protected]>
…ng ostree systems Signed-off-by: James Miller <[email protected]>
Signed-off-by: James Miller <[email protected]>
Signed-off-by: James Miller <[email protected]>
Sure, sometimes a Pr gets messed up. No worries :) I have taken a cursory look at your PR and I would like you to use the variable Other than that your changes seem to break some tests and we need to address this. |
Introduced new default var
os_immutable_fs
which defaults toansible_facts.pkg_mgr not 'atomic_container'
.Prevented ansible.builtin.packages and yum etc from installing or removing files on atomic_container systems, due to requirement to reboot and to use community.general.rpm_ostree instead of ansible.builtin.packages
os_hardening now runs without fail on my core_os system. I set