Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'import type' for types instead of 'import' #636

Merged
merged 14 commits into from
Mar 7, 2022
Merged

Conversation

krzkaczor
Copy link
Member

  • importing types without 'import type' was problamatic with svelte vite

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2022

🦋 Changeset detected

Latest commit: 408c884

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@typechain/hardhat Minor
@typechain/ethers-v5 Minor
@typechain/web3-v1 Minor
typechain Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@krzkaczor
Copy link
Member Author

I removed changes in unreleated files (we don't want to use import type internally). I made generated import statements consistent - we don't need import type from module x if we import runtime objects from x. At least according to: microsoft/TypeScript#39432 (comment)

@krzkaczor
Copy link
Member Author

Original work done in: #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants