Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run jest with 7 workers in ci #6043

Closed
wants to merge 1 commit into from

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Feb 22, 2023

Description

This limits the react tests to running with 7 workers in ci. This is because jest runs with one worker per detected cpu core and this number exceeds the cores we have available to us in the container. This can cause our test execution to get throttled, which can cause our tests to run slower than usual and possibly timeout. Because we're looking to move from jest anyways, the purpose of posting this pull request is to compare its runtimes to the runtimes on master and to the #5926 draft pr.

Test Plan

unit-test-react should continue to pass.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Feb 22, 2023
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d3f0d35
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/64064195240278000742647d
😎 Deploy Preview https://deploy-preview-6043--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ashtonG ashtonG changed the title run jest with 7 workers in ci build: run jest with 7 workers in ci Feb 22, 2023
@ashtonG ashtonG force-pushed the build/WEB-906/jest-7-cores branch from 0ac15d8 to d3f0d35 Compare March 6, 2023 19:40
@ashtonG ashtonG closed this Mar 7, 2023
@ashtonG ashtonG deleted the build/WEB-906/jest-7-cores branch March 7, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant