-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change min npm version #5966
Conversation
❌ Deploy Preview for determined-ui failed.
|
01a8fd6
to
f083d0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to address this! I left some comments.
webui/react/package.json
Outdated
@@ -4,7 +4,7 @@ | |||
"private": true, | |||
"engines": { | |||
"node": ">=16.13 <17", | |||
"npm": ">=8.0.0" | |||
"npm": ">=9.4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is there a way to have multiple npm version ranges? Specifically something like:
"npm": ">=8.0.0 <9.0.0, >=9.4.2"
If we can do something like that, then we can skip the use-npm-v9
step and just use the current npm version that comes with 16.14.2
for now and wait for the next node/npm upgrade so we don't have run an extra step to just update npm
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can do something like "npm": ">=8.0.0 <= 9.4.2"
. not sure we can do "npm": ">=8.0.0 <9.0.0, >=9.4.2"
. let me check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc says we can do "npm": ">=8.0.0 <9.0.0 || >=9.4.2"
.circleci/config.yml
Outdated
@@ -100,6 +100,10 @@ commands: | |||
- run: git submodule sync | |||
- run: git submodule update --init | |||
|
|||
use-npm-v9: | |||
steps: | |||
- run: npm i -g [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit question: would this be better?
- run: npm i -g npm@^9.4.2
I can't remember the exact syntax but the idea is to get whatever newer patch version is compared to 9.4.2
so we're not specifically pinned to 9.4.2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe different npm version would cause some issues, but i think its more stable to use a specific npm version.
but the issue here is that - run: npm i -g npm
doesnt work on circleci due to the permission error. not sure how to resolve the issue
this issue is resolved by "npm": ">=8.0.0 <9.0.0 || >=9.4.2"
f083d0d
to
bb53b00
Compare
close this due to some issues |
Description
Follow up of #5926
Test Plan
make clean
to removebuild
,node_modules
etcnpm i
ormake get-deps
to install npm modulesmake live
to check if it worksmake build
to check if module can be builtCommentary (optional)
Adjusted
package-lock.json
for npm v9. Lock file version is now v3.npm v9 is compatible with our current node version ^v16.13. resource
Checklist
docs/release-notes/
.See Release Note for details.
Ticket