Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to Shouldly #90

Merged
merged 1 commit into from
Jan 23, 2024
+287 −291
Merged

Migrate tests to Shouldly #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/Destructurama.Attributed.Tests/AttributedDestructuringTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using NUnit.Framework;
using Serilog;
using Serilog.Events;
using Shouldly;

namespace Destructurama.Attributed.Tests;

Expand Down Expand Up @@ -37,17 +38,17 @@ public void AttributesAreConsultedWhenDestructuring()
var sv = (StructureValue)evt.Properties["Customized"];
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsInstanceOf<ImmutableScalar>(props["ImmutableScalar"].LiteralValue());
Assert.AreEqual(new MutableScalar().ToString(), props["MutableScalar"].LiteralValue());
Assert.IsInstanceOf<StructureValue>(props["NotAScalar"]);
Assert.IsFalse(props.ContainsKey("Ignored"));
Assert.IsInstanceOf<NotAScalar>(props["ScalarAnyway"].LiteralValue());
Assert.IsInstanceOf<Struct1>(props["Struct1"].LiteralValue());
Assert.IsInstanceOf<Struct2>(props["Struct2"].LiteralValue());
props["ImmutableScalar"].LiteralValue().ShouldBeOfType<ImmutableScalar>();
props["MutableScalar"].LiteralValue().ShouldBe(new MutableScalar().ToString());
props["NotAScalar"].ShouldBeOfType<StructureValue>();
props.ContainsKey("Ignored").ShouldBeFalse();
props["ScalarAnyway"].LiteralValue().ShouldBeOfType<NotAScalar>();
props["Struct1"].LiteralValue().ShouldBeOfType<Struct1>();
props["Struct2"].LiteralValue().ShouldBeOfType<Struct2>();

var str = sv.ToString();
Assert.That(str.Contains("This is a username"));
Assert.False(str.Contains("This is a password"));
str.Contains("This is a username").ShouldBeTrue();
str.Contains("This is a password").ShouldBeFalse();
}

[LogAsScalar]
Expand Down
262 changes: 128 additions & 134 deletions src/Destructurama.Attributed.Tests/IgnoreNullPropertiesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using NUnit.Framework;
using Serilog;
using Serilog.Events;
using Shouldly;

namespace Destructurama.Attributed.Tests;

Expand Down Expand Up @@ -162,17 +163,17 @@
var sv = (StructureValue)evt!.Properties["Customized"];
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(props.ContainsKey("Integer"));
Assert.IsTrue(props.ContainsKey("DateTime"));
Assert.IsTrue(props.ContainsKey("Struct"));
Assert.IsTrue(props.ContainsKey("StructPartiallyInitialized"));

Assert.IsFalse(props.ContainsKey("String"));
Assert.IsFalse(props.ContainsKey("NullableInteger"));
Assert.IsFalse(props.ContainsKey("IntegerAsObject"));
Assert.IsFalse(props.ContainsKey("Object"));
Assert.IsFalse(props.ContainsKey("NullableDateTime"));
Assert.IsFalse(props.ContainsKey("NullableStruct"));
props.ContainsKey("Integer").ShouldBeTrue();
props.ContainsKey("DateTime").ShouldBeTrue();
props.ContainsKey("Struct").ShouldBeTrue();
props.ContainsKey("StructPartiallyInitialized").ShouldBeTrue();

props.ContainsKey("String").ShouldBeFalse();
props.ContainsKey("NullableInteger").ShouldBeFalse();
props.ContainsKey("IntegerAsObject").ShouldBeFalse();
props.ContainsKey("Object").ShouldBeFalse();
props.ContainsKey("NullableDateTime").ShouldBeFalse();
props.ContainsKey("NullableStruct").ShouldBeFalse();
}

[Test]
Expand Down Expand Up @@ -223,54 +224,52 @@
var sv = (StructureValue)evt!.Properties["Customized"];
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(props.ContainsKey("String"));
Assert.IsTrue(props.ContainsKey("Integer"));
Assert.IsTrue(props.ContainsKey("NullableInteger"));
Assert.IsTrue(props.ContainsKey("Object"));
Assert.IsTrue(props.ContainsKey("IntegerAsObject"));
Assert.IsTrue(props.ContainsKey("DateTime"));
Assert.IsTrue(props.ContainsKey("NullableDateTime"));
Assert.IsTrue(props.ContainsKey("Struct"));
Assert.IsTrue(props.ContainsKey("NullableStruct"));
Assert.IsTrue(props.ContainsKey("StructPartiallyInitialized"));

Assert.AreEqual("Foo", props["String"].LiteralValue());
Assert.AreEqual(10, props["Integer"].LiteralValue());
Assert.AreEqual(5, props["NullableInteger"].LiteralValue());
Assert.AreEqual("Bar", props["Object"].LiteralValue());
Assert.AreEqual(0, props["IntegerAsObject"].LiteralValue());
Assert.AreEqual(dateTime, props["DateTime"].LiteralValue());
Assert.AreEqual(dateTime, props["NullableDateTime"].LiteralValue());
Assert.IsInstanceOf<StructureValue>(props["Struct"]);
Assert.IsInstanceOf<StructureValue>(props["NullableStruct"]);
Assert.IsInstanceOf<StructureValue>(props["StructPartiallyInitialized"]);

var structProps = ((StructureValue)props["Struct"]).Properties
.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(structProps.ContainsKey("Integer"));
Assert.IsTrue(structProps.ContainsKey("NullableInteger"));
Assert.IsTrue(structProps.ContainsKey("DateTime"));
Assert.IsTrue(structProps.ContainsKey("NullableDateTime"));
Assert.IsTrue(structProps.ContainsKey("Object"));
Assert.AreEqual(20, structProps["Integer"].LiteralValue());
Assert.AreEqual(15, structProps["NullableInteger"].LiteralValue());
Assert.AreEqual(dateTime, structProps["DateTime"].LiteralValue());
Assert.AreEqual(dateTime, structProps["NullableDateTime"].LiteralValue());
Assert.AreEqual("Bar", structProps["Object"].LiteralValue());

var partiallyItitializedProps = ((StructureValue)props["StructPartiallyInitialized"]).Properties
.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(partiallyItitializedProps.ContainsKey("Integer"));
Assert.IsTrue(partiallyItitializedProps.ContainsKey("NullableInteger"));
Assert.IsTrue(partiallyItitializedProps.ContainsKey("DateTime"));
Assert.IsTrue(partiallyItitializedProps.ContainsKey("NullableDateTime"));
Assert.IsFalse(partiallyItitializedProps.ContainsKey("Object"));
Assert.AreEqual(20, partiallyItitializedProps["Integer"].LiteralValue());
Assert.AreEqual(15, partiallyItitializedProps["NullableInteger"].LiteralValue());
Assert.AreEqual(dateTime, partiallyItitializedProps["DateTime"].LiteralValue());
Assert.AreEqual(dateTime, partiallyItitializedProps["NullableDateTime"].LiteralValue());
props.ContainsKey("String").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("Integer").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("NullableInteger").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("Object").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("IntegerAsObject").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("DateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("NullableDateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("Struct").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("NullableStruct").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("StructPartiallyInitialized").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
Inefficient use of 'ContainsKey' and
indexer
Loading
.

props["String"].LiteralValue().ShouldBe("Foo");
props["Integer"].LiteralValue().ShouldBe(10);
props["NullableInteger"].LiteralValue().ShouldBe(5);
props["Object"].LiteralValue().ShouldBe("Bar");
props["IntegerAsObject"].LiteralValue().ShouldBe(0);
props["DateTime"].LiteralValue().ShouldBe(dateTime);
props["NullableDateTime"].LiteralValue().ShouldBe(dateTime);
props["Struct"].ShouldBeOfType<StructureValue>();
props["NullableStruct"].ShouldBeOfType<StructureValue>();
props["StructPartiallyInitialized"].ShouldBeOfType<StructureValue>();

var structProps = ((StructureValue)props["Struct"]).Properties.ToDictionary(p => p.Name, p => p.Value);

structProps.ContainsKey("Integer").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps.ContainsKey("NullableInteger").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps.ContainsKey("DateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps.ContainsKey("NullableDateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps.ContainsKey("Object").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps["Integer"].LiteralValue().ShouldBe(20);
structProps["NullableInteger"].LiteralValue().ShouldBe(15);
structProps["DateTime"].LiteralValue().ShouldBe(dateTime);
structProps["NullableDateTime"].LiteralValue().ShouldBe(dateTime);
structProps["Object"].LiteralValue().ShouldBe("Bar");

var partiallyItitializedProps = ((StructureValue)props["StructPartiallyInitialized"]).Properties.ToDictionary(p => p.Name, p => p.Value);

partiallyItitializedProps.ContainsKey("Integer").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
partiallyItitializedProps.ContainsKey("NullableInteger").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
partiallyItitializedProps.ContainsKey("DateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
partiallyItitializedProps.ContainsKey("NullableDateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
partiallyItitializedProps.ContainsKey("Object").ShouldBeFalse();
partiallyItitializedProps["Integer"].LiteralValue().ShouldBe(20);
partiallyItitializedProps["NullableInteger"].LiteralValue().ShouldBe(15);
partiallyItitializedProps["DateTime"].LiteralValue().ShouldBe(dateTime);
partiallyItitializedProps["NullableDateTime"].LiteralValue().ShouldBe(dateTime);
}

[Test]
Expand All @@ -290,8 +289,8 @@
var sv = (StructureValue)evt!.Properties["Customized"];
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsFalse(props.ContainsKey("String"));
Assert.IsFalse(props.ContainsKey("Object"));
props.ContainsKey("String").ShouldBeFalse();
props.ContainsKey("Object").ShouldBeFalse();
}

[Test]
Expand All @@ -316,11 +315,11 @@
var sv = (StructureValue)evt!.Properties["Customized"];
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(props.ContainsKey("String"));
Assert.IsTrue(props.ContainsKey("Object"));
props.ContainsKey("String").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("Object").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.

Assert.AreEqual("Foo***", props["String"].LiteralValue());
Assert.AreEqual("Bar***", props["Object"].LiteralValue());
props["String"].LiteralValue().ShouldBe("Foo***");
props["Object"].LiteralValue().ShouldBe("Bar***");
}

[Test]
Expand All @@ -345,7 +344,7 @@
log.Information("Here is {@Customized}", customized);

var sv = evt!.Properties["Customized"];
Assert.IsInstanceOf<SequenceValue>(sv);
sv.ShouldBeOfType<SequenceValue>();
}

[Test]
Expand Down Expand Up @@ -373,15 +372,14 @@
var sv = (StructureValue)evt!.Properties["Customized"];
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(props.ContainsKey("Integer"));
Assert.IsFalse(props.ContainsKey("NullableInteger"));
Assert.IsTrue(props.ContainsKey("Dependency"));
props.ContainsKey("Integer").ShouldBeTrue();
props.ContainsKey("NullableInteger").ShouldBeFalse();
props.ContainsKey("Dependency").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.

var dependencyProps = ((StructureValue)props["Dependency"]).Properties
.ToDictionary(p => p.Name, p => p.Value);
var dependencyProps = ((StructureValue)props["Dependency"]).Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(dependencyProps.ContainsKey("Integer"));
Assert.IsFalse(dependencyProps.ContainsKey("NullableInteger"));
dependencyProps.ContainsKey("Integer").ShouldBeTrue();
dependencyProps.ContainsKey("NullableInteger").ShouldBeFalse();
}

[Test]
Expand All @@ -401,17 +399,17 @@
var sv = (StructureValue)evt!.Properties["Customized"];
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(props.ContainsKey("Integer"));
Assert.IsTrue(props.ContainsKey("DateTime"));
Assert.IsTrue(props.ContainsKey("Struct"));
Assert.IsTrue(props.ContainsKey("StructPartiallyInitialized"));

Assert.IsFalse(props.ContainsKey("String"));
Assert.IsFalse(props.ContainsKey("NullableInteger"));
Assert.IsFalse(props.ContainsKey("IntegerAsObject"));
Assert.IsFalse(props.ContainsKey("Object"));
Assert.IsFalse(props.ContainsKey("NullableDateTime"));
Assert.IsFalse(props.ContainsKey("NullableStruct"));
props.ContainsKey("Integer").ShouldBeTrue();
props.ContainsKey("DateTime").ShouldBeTrue();
props.ContainsKey("Struct").ShouldBeTrue();
props.ContainsKey("StructPartiallyInitialized").ShouldBeTrue();

props.ContainsKey("String").ShouldBeFalse();
props.ContainsKey("NullableInteger").ShouldBeFalse();
props.ContainsKey("IntegerAsObject").ShouldBeFalse();
props.ContainsKey("Object").ShouldBeFalse();
props.ContainsKey("NullableDateTime").ShouldBeFalse();
props.ContainsKey("NullableStruct").ShouldBeFalse();
}

[Test]
Expand Down Expand Up @@ -462,57 +460,53 @@
var sv = (StructureValue)evt!.Properties["Customized"];
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(props.ContainsKey("String"));
Assert.IsTrue(props.ContainsKey("Integer"));
Assert.IsTrue(props.ContainsKey("NullableInteger"));
Assert.IsTrue(props.ContainsKey("Object"));
Assert.IsTrue(props.ContainsKey("IntegerAsObject"));
Assert.IsTrue(props.ContainsKey("DateTime"));
Assert.IsTrue(props.ContainsKey("NullableDateTime"));
Assert.IsTrue(props.ContainsKey("Struct"));
Assert.IsTrue(props.ContainsKey("NullableStruct"));
Assert.IsTrue(props.ContainsKey("StructPartiallyInitialized"));

Assert.AreEqual("Foo", props["String"].LiteralValue());
Assert.AreEqual(10, props["Integer"].LiteralValue());
Assert.AreEqual(5, props["NullableInteger"].LiteralValue());
Assert.AreEqual("Bar", props["Object"].LiteralValue());
Assert.AreEqual(0, props["IntegerAsObject"].LiteralValue());
Assert.AreEqual(dateTime, props["DateTime"].LiteralValue());
Assert.AreEqual(dateTime, props["NullableDateTime"].LiteralValue());
Assert.IsInstanceOf<StructureValue>(props["Struct"]);
Assert.IsInstanceOf<StructureValue>(props["NullableStruct"]);
Assert.IsInstanceOf<StructureValue>(props["StructPartiallyInitialized"]);

var structProps = ((StructureValue)props["Struct"]).Properties
.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(structProps.ContainsKey("Integer"));
Assert.IsTrue(structProps.ContainsKey("NullableInteger"));
Assert.IsTrue(structProps.ContainsKey("DateTime"));
Assert.IsTrue(structProps.ContainsKey("NullableDateTime"));
Assert.IsTrue(structProps.ContainsKey("Object"));
Assert.AreEqual(20, structProps["Integer"].LiteralValue());
Assert.AreEqual(15, structProps["NullableInteger"].LiteralValue());
Assert.AreEqual(dateTime, structProps["DateTime"].LiteralValue());
Assert.AreEqual(dateTime, structProps["NullableDateTime"].LiteralValue());
Assert.AreEqual("Bar", structProps["Object"].LiteralValue());

var partiallyItitializedProps = ((StructureValue)props["StructPartiallyInitialized"]).Properties
.ToDictionary(p => p.Name, p => p.Value);

Assert.IsTrue(partiallyItitializedProps.ContainsKey("Integer"));
Assert.IsTrue(partiallyItitializedProps.ContainsKey("NullableInteger"));
Assert.IsTrue(partiallyItitializedProps.ContainsKey("DateTime"));
Assert.IsTrue(partiallyItitializedProps.ContainsKey("NullableDateTime"));
Assert.IsTrue(partiallyItitializedProps.ContainsKey("Object"));
Assert.AreEqual(20, partiallyItitializedProps["Integer"].LiteralValue());
Assert.AreEqual(15, partiallyItitializedProps["NullableInteger"].LiteralValue());
Assert.AreEqual(dateTime, partiallyItitializedProps["DateTime"].LiteralValue());
Assert.AreEqual(dateTime, partiallyItitializedProps["NullableDateTime"].LiteralValue());

props.ContainsKey("String").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("Integer").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("NullableInteger").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("Object").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("IntegerAsObject").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("DateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("NullableDateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("Struct").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("NullableStruct").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
props.ContainsKey("StructPartiallyInitialized").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
Inefficient use of 'ContainsKey' and
indexer
Loading
.

props["String"].LiteralValue().ShouldBe("Foo");
props["Integer"].LiteralValue().ShouldBe(10);
props["NullableInteger"].LiteralValue().ShouldBe(5);
props["Object"].LiteralValue().ShouldBe("Bar");
props["IntegerAsObject"].LiteralValue().ShouldBe(0);
props["DateTime"].LiteralValue().ShouldBe(dateTime);
props["NullableDateTime"].LiteralValue().ShouldBe(dateTime);
props["Struct"].ShouldBeOfType<StructureValue>();
props["NullableStruct"].ShouldBeOfType<StructureValue>();
props["StructPartiallyInitialized"].ShouldBeOfType<StructureValue>();

var structProps = ((StructureValue)props["Struct"]).Properties.ToDictionary(p => p.Name, p => p.Value);

structProps.ContainsKey("Integer").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps.ContainsKey("NullableInteger").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps.ContainsKey("DateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps.ContainsKey("NullableDateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps.ContainsKey("Object").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
structProps["Integer"].LiteralValue().ShouldBe(20);
structProps["NullableInteger"].LiteralValue().ShouldBe(15);
structProps["DateTime"].LiteralValue().ShouldBe(dateTime);
structProps["NullableDateTime"].LiteralValue().ShouldBe(dateTime);
structProps["Object"].LiteralValue().ShouldBe("Bar");

var partiallyItitializedProps = ((StructureValue)props["StructPartiallyInitialized"]).Properties.ToDictionary(p => p.Name, p => p.Value);

partiallyItitializedProps.ContainsKey("Integer").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
partiallyItitializedProps.ContainsKey("NullableInteger").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
partiallyItitializedProps.ContainsKey("DateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
partiallyItitializedProps.ContainsKey("NullableDateTime").ShouldBeTrue();

Check notice

Code scanning / CodeQL

Inefficient use of ContainsKey Note test

Inefficient use of 'ContainsKey' and
indexer
Loading
.
partiallyItitializedProps.ContainsKey("Object").ShouldBeTrue();
partiallyItitializedProps["Integer"].LiteralValue().ShouldBe(20);
partiallyItitializedProps["NullableInteger"].LiteralValue().ShouldBe(15);
partiallyItitializedProps["DateTime"].LiteralValue().ShouldBe(dateTime);
partiallyItitializedProps["NullableDateTime"].LiteralValue().ShouldBe(dateTime);
}

}


4 changes: 2 additions & 2 deletions src/Destructurama.Attributed.Tests/LogWithNameAttributedTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
using NUnit.Framework;
using Serilog;
using Serilog.Events;
using Shouldly;

namespace Destructurama.Attributed.Tests;

[TestFixture]
public class LogWithNameAttributedTests
{

[Test]
public void AttributesAreConsultedWhenDestructuring()
{
Expand All @@ -30,7 +30,7 @@ public void AttributesAreConsultedWhenDestructuring()
var props = sv.Properties.ToDictionary(p => p.Name, p => p.Value);

var literalValue = props["FullName"].LiteralValue();
Assert.AreEqual("John Doe", literalValue);
literalValue.ShouldBe("John Doe");
}

#region LogWithName
Expand Down
Loading
Loading