gmag bug in quickcat?

[moustakas]

@forero Is this code block in quickcat a bug?

DECAM_FLUX returns fluxes in nanomaggies but line 218 treats the g-band flux as a magnitude.

[If this is indeed a bug I can fix it on the branch I'm working on now, which is updating the targets and truth tables to the latest imaging data model.]

[forero]

I don't know if that's a bug. It looks like it is one.
Consult first with @cballand . He wrote those lines.

[moustakas]

Apologies, I thought you wrote quickcat, @forero!

[forero]

Don't worry! quickcat has been a real collaborative effort!

[cballand]

I had a quick look and I'm not sure it's a bug (but I should check this in more detail): as far as true_gmag and qso_gmag_threshold are in the same units (nanomaggies), the flux ratio should be expressed as it is on line 218 (i.e., it should only depend on the difference true_gmag - qso_gmag_threshold).

[cballand]

In fact you're right, this is a bug, true_gmag is a flux in nanomaggies and should be converted into a magnitude before being used in line 218.

[moustakas]

OK, great. I've fixed this in my branch and will merge after Stephen's PR.

…

On Aug 1, 2017 7:30 PM, "cballand" ***@***.***> wrote: In fact you're right, this is a bug, true_gmag is a flux in nanomaggies and should be converted into a magnitude before being used in line 218. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#251 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXZDHaqZj9YJqP_8krMhlFXAAF273e5ks5sT7T9gaJpZM4Opu4P> .

[cballand]

Ok, thanks @moustakas

[moustakas]

Fixed in #252.