Skip to content

Commit

Permalink
fix: remark-lint no-heading-indent (nodejs#349)
Browse files Browse the repository at this point in the history
Cleaned up other minor whitespace issues at the same time
  • Loading branch information
nschonni authored and MylesBorins committed Oct 18, 2019
1 parent b27300d commit 7794efb
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 47 deletions.
1 change: 0 additions & 1 deletion .remarkrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
["remark-lint-maximum-line-length", false],
["remark-lint-no-blockquote-without-marker", false],
["remark-lint-no-consecutive-blank-lines", false],
["remark-lint-no-heading-indent", false],
["remark-lint-no-inline-padding", false],
["remark-lint-no-multiple-toplevel-headings", false],
["remark-lint-no-tabs", false],
Expand Down
88 changes: 42 additions & 46 deletions meetings/2019-06-06.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,76 +7,72 @@
* **Minutes Google Doc**: $MINUTES_DOC$

## Present

@LaRuaNa
@jonchurch

* Website Redesign Strategic Initiative Team: @nodejs/website-redesign




## Agenda

## Announcements

*Extracted from **wr-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.
## Agenda

### nodejs/website-redesign
## Announcements

* Create data contract for how API documentation will be consumed [#158](https://github.com/nodejs/website-redesign/issues/158)
What format are the docs in currently? Are they managing metadata, what is that metadata, what does it do? Do we intend to use it?
*Extracted from **wr-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/nodejs.dev
### nodejs/website-redesign

* SPIKE: In Our Perfect World, In What Format Would the API Be Documented? [#258](https://github.com/nodejs/nodejs.dev/issues/258)
* Create data contract for how API documentation will be consumed [#158](https://github.com/nodejs/website-redesign/issues/158)
What format are the docs in currently? Are they managing metadata, what is that metadata, what does it do? Do we intend to use it?

What metadata do we want to record? That could inform what format we use. Maybe frontmatter? Let’s discuss at the next meeting when we have more people
### nodejs/nodejs.dev

* Integrate Algolia Code Search [#257](https://github.com/nodejs/nodejs.dev/issues/257)
* SPIKE: In Our Perfect World, In What Format Would the API Be Documented? [#258](https://github.com/nodejs/nodejs.dev/issues/258)

How to integrate algolia indexing with the different versions of the docs? v12 vs v10 etc
The search should be linked to the current version of the docs that you are looking at.
We don’t know yet how to support searching in multiple versions of the docs
What metadata do we want to record? That could inform what format we use. Maybe frontmatter? Let’s discuss at the next meeting when we have more people

* Integrate API JSON as an async data source [#255](https://github.com/nodejs/nodejs.dev/issues/255)
Skipping, because it requires research and context that we don’t have in this meeting
* Integrate Algolia Code Search [#257](https://github.com/nodejs/nodejs.dev/issues/257)

* Select and Integrate an i18n Library [#254](https://github.com/nodejs/nodejs.dev/issues/254)
How to integrate algolia indexing with the different versions of the docs? v12 vs v10 etc
The search should be linked to the current version of the docs that you are looking at.
We don’t know yet how to support searching in multiple versions of the docs

We will create an npm package with all the text of the different languages for the documentation.
We need to check if there are any complications in integrating an npm package with the gatsby i18n plugin we choose.
maybe use react-intl https://github.com/formatjs/react-intl
or maybe react-i18next https://github.com/i18next/react-i18next/
* Integrate API JSON as an async data source [#255](https://github.com/nodejs/nodejs.dev/issues/255)
Skipping, because it requires research and context that we don’t have in this meeting

* chore: Eslint / Prettier integration. [#179](https://github.com/nodejs/nodejs.dev/pull/179)
@LaRuaNa is working on this, needs to find the time to rewrite the code
* Select and Integrate an i18n Library [#254](https://github.com/nodejs/nodejs.dev/issues/254)

Mentoring/Pair coding program for new contributors?
Maybe issue tagging? “Good first issue”
Maybe livestream contributing? Show people how to get involved. Or just record a “getting started” type of resource.
Ask manil about the mentoring program/intro to OSS he has worked.
Maybe plan the stream ahead of time, create and tag good intro issues, select which ones we will work on live, and advertise it on twitter.
We will create an npm package with all the text of the different languages for the documentation.
We need to check if there are any complications in integrating an npm package with the gatsby i18n plugin we choose.
maybe use react-intl https://github.com/formatjs/react-intl
or maybe react-i18next https://github.com/i18next/react-i18next/

Reopened the idea of merging the two repos together https://github.com/nodejs/website-redesign/issues/147
* chore: Eslint / Prettier integration. [#179](https://github.com/nodejs/nodejs.dev/pull/179)
@LaRuaNa is working on this, needs to find the time to rewrite the code

Mentoring/Pair coding program for new contributors?
Maybe issue tagging? “Good first issue”
Maybe livestream contributing? Show people how to get involved. Or just record a “getting started” type of resource.
Ask manil about the mentoring program/intro to OSS he has worked.
Maybe plan the stream ahead of time, create and tag good intro issues, select which ones we will work on live, and advertise it on twitter.

There are new project boards for each page of the new site
https://github.com/nodejs/nodejs.dev/projects
@LaRuaNa will organize some of these
Reopened the idea of merging the two repos together https://github.com/nodejs/website-redesign/issues/147

Link to new design system, in progress. Click the node logo to switch between light and dark modes
https://www.figma.com/proto/brsBURZIKRBj7JAmMMCz2rlz/NJ---Design-System?node-id=90%3A4958&scaling=min-zoom&redirected=1
There are new project boards for each page of the new site
https://github.com/nodejs/nodejs.dev/projects
@LaRuaNa will organize some of these

Knowledge base articles
They’re being worked on in the Node.js org currently, we need to make sure these aren’t being worked on in two places. they aren’t currently linked to on the nodejs.org site, so they don’t really need to be in that repo.
We could pull them into the nodejs.dev repo and work on them there.
We should figure out what articles from the knowledge base we want to use, which are duplicates of what we already have, and how we want to use the knowledge base info (if at all).
Link to new design system, in progress. Click the node logo to switch between light and dark modes
https://www.figma.com/proto/brsBURZIKRBj7JAmMMCz2rlz/NJ---Design-System?node-id=90%3A4958&scaling=min-zoom&redirected=1

## Q&A, Other
Knowledge base articles
They’re being worked on in the Node.js org currently, we need to make sure these aren’t being worked on in two places. they aren’t currently linked to on the nodejs.org site, so they don’t really need to be in that repo.
We could pull them into the nodejs.dev repo and work on them there.
We should figure out what articles from the knowledge base we want to use, which are duplicates of what we already have, and how we want to use the knowledge base info (if at all).

## Upcoming Meetings
## Q&A, Other

* **Node.js Foundation Calendar**: https://nodejs.org/calendar
## Upcoming Meetings

Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.
* **Node.js Foundation Calendar**: https://nodejs.org/calendar

Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.

0 comments on commit 7794efb

Please sign in to comment.