Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types declaration file #4

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Add types declaration file #4

merged 2 commits into from
Nov 25, 2020

Conversation

geopic
Copy link
Contributor

@geopic geopic commented Nov 23, 2020

Resolves #2. Let me know if there are any issues.

@desholmes
Copy link
Owner

@geopic This looks great. Do you think it would be helpful to update the README.md to include a TypeScript usage example too?

@geopic
Copy link
Contributor Author

geopic commented Nov 24, 2020

@geopic This looks great. Do you think it would be helpful to update the README.md to include a TypeScript usage example too?

No worries, I'll add an example to the Readme.

Copy link
Owner

@desholmes desholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! LGTM 💪

@@ -63,7 +63,7 @@ import "text-terminal/dist/text-terminal.css";
const commands = {};

const config = {
containerId = "text-terminal",
containerId: "text-terminal",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 Good catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@desholmes desholmes merged commit 768c32c into desholmes:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript type declaration file
2 participants