Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common-js build (Breaking Changes) #437

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Fix common-js build (Breaking Changes) #437

merged 5 commits into from
Feb 20, 2025

Conversation

asafshen
Copy link
Member

@asafshen asafshen commented Feb 19, 2025

Related Issues

https://github.com/descope/etc/issues/9394

Description

** breaking changes **

change the descope errors to be a constant on the named error

this will require to bump a minor version

Need to change:

import { SdkResponse, descopeErrors } from '@descope/node-sdk';

To:

import DescopeClient, { SdkResponse } from '@descope/node-sdk';

const { DescopeErrors } = DescopeClient;

@asafshen asafshen requested a review from dorsha February 20, 2025 09:36
@asafshen asafshen marked this pull request as ready for review February 20, 2025 09:36
@asafshen asafshen enabled auto-merge (squash) February 20, 2025 09:37
@asafshen asafshen disabled auto-merge February 20, 2025 09:37
@asafshen asafshen enabled auto-merge (squash) February 20, 2025 09:37
@asafshen asafshen disabled auto-merge February 20, 2025 09:37
@asafshen asafshen enabled auto-merge (squash) February 20, 2025 09:37
@asafshen asafshen merged commit c45b0f0 into main Feb 20, 2025
9 checks passed
@asafshen asafshen deleted the fix-commonjs-build branch February 20, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants