fix: always check subprocess return codes

desbma · Jan 1, 2025 · 376291a · 376291a
1 parent 8d287d1
commit 376291a
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/src/device/drive.rs b/src/device/drive.rs
@@ -80,6 +80,10 @@ impl Drive {
                 .stdout(Stdio::piped())
                 .stderr(Stdio::null())
                 .output()?;
+            if !output.status.success() {
+                log::trace!("{}", output.status);
+                continue;
+            }
             // log::trace!("{}", std::str::from_utf8(&output.stdout).unwrap());
             if let Some(line) = output.stdout.lines().map_while(Result::ok).find(|l| {
                 let l = l.trim_start();
@@ -104,6 +108,11 @@ impl Drive {
             .stdout(Stdio::piped())
             .stderr(Stdio::null())
             .output()?;
+        anyhow::ensure!(
+            output.status.success(),
+            "hdparm failed with code {}",
+            output.status
+        );
         let state = output
             .stdout
             .lines()

diff --git a/src/probe/hddtemp.rs b/src/probe/hddtemp.rs
@@ -124,6 +124,11 @@ impl DeviceTempProber for InvocationProber {
             .stderr(Stdio::null())
             .env("LANG", "C")
             .output()?;
+        anyhow::ensure!(
+            output.status.success(),
+            "hddtemp failed with code {}",
+            output.status
+        );
         // TODO handle "drive is sleeping" case
         let temp = str::from_utf8(&output.stdout)?.trim_end().parse()?;
         Ok(temp)

diff --git a/src/probe/smartctl.rs b/src/probe/smartctl.rs
@@ -54,6 +54,11 @@ impl DeviceTempProber for SctProber {
             .stderr(Stdio::null())
             .env("LANG", "C")
             .output()?;
+        anyhow::ensure!(
+            output.status.success(),
+            "smartctl failed with code {}",
+            output.status
+        );
         let temp = output
             .stdout
             .lines()
@@ -162,6 +167,11 @@ impl DeviceTempProber for AttribProber {
             .stderr(Stdio::null())
             .env("LANG", "C")
             .output()?;
+        anyhow::ensure!(
+            output.status.success(),
+            "smartctl failed with code {}",
+            output.status
+        );
         let temp = output
             .stdout
             .lines()