Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: update x/tools for go1.18 support #22

Merged
merged 1 commit into from
Mar 28, 2022
Merged

gomod: update x/tools for go1.18 support #22

merged 1 commit into from
Mar 28, 2022

Conversation

keegancsmith
Copy link
Contributor

@keegancsmith keegancsmith commented Mar 28, 2022

Before this commit go-mockgen fails on go1.18 code with errors like:

internal error: package "context" without types was imported from "package/name/here"

This commit updates the dependency. After this update go-mockgen works.

Note: the dependencies in this repository are important. In newer versions of go if you run "go install go-mockgen@version" it uses the module file in this repository, not your repository.

Note: we update all dependencies. We can limit this just to the relevant deps.

Before this commit go-mockgen fails on go1.18 code with errors like:

  internal error: package "context" without types was imported from "package/name/here"

This commit updates the dependency. After this update go-mockgen works.

Note: the dependencies in this repository are important. In newer
versions of go if you run "go install go-mockgen@version" it uses the
module file in this repository, not your repository.

Note: we update all dependencies. We can limit this just to the relevant
deps.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@efritz efritz merged commit 7266d9d into derision-test:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants