Skip to content

Commit

Permalink
Merge pull request apache#11556 from deqingli/master
Browse files Browse the repository at this point in the history
fix tree diagram leaves label formatter don't work apache#11385 apache#8534
  • Loading branch information
deqingli authored Nov 6, 2019
2 parents 33d14b8 + f010225 commit 0f90a73
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 6 deletions.
13 changes: 12 additions & 1 deletion src/chart/tree/TreeSeries.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,18 @@ export default SeriesModel.extend({

treeOption.leaves = leaves;

var tree = Tree.createTree(root, this, treeOption);
var tree = Tree.createTree(root, this, treeOption, beforeLink);

function beforeLink(nodeData) {
nodeData.wrapMethod('getItemModel', function (model, idx) {
var node = tree.getNodeByDataIndex(idx);
var leavesModel = node.getLeavesModel();
if (!node.children.length || !node.isExpand) {
model.parentModel = leavesModel;
}
return model;
});
}

var treeDepth = 0;

Expand Down
4 changes: 3 additions & 1 deletion src/data/Tree.js
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ Tree.prototype = {
* @param {Array.<Object>} treeOptions.leaves
* @return module:echarts/data/Tree
*/
Tree.createTree = function (dataRoot, hostModel, treeOptions) {
Tree.createTree = function (dataRoot, hostModel, treeOptions, beforeLink) {

var tree = new Tree(hostModel, treeOptions.levels, treeOptions.leaves);
var listData = [];
Expand Down Expand Up @@ -519,6 +519,8 @@ Tree.createTree = function (dataRoot, hostModel, treeOptions) {

tree.update();

beforeLink && beforeLink(list);

return tree;
};

Expand Down
16 changes: 12 additions & 4 deletions test/tree-addNode.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,18 @@

var data = {
"name": "flare",
"value": 111,
"children": [
{
"name": "flex",
"value": 222,
"children": [
{"name": "FlareVis", "value": 4116, symbolSize: 20}
]
},
{
"name": "scale",
"value": 333,
"children": [
{"name": "IScaleMap", "value": 2105},
{"name": "LinearScale", "value": 1316},
Expand All @@ -73,6 +76,7 @@
},
{
"name": "display",
"value": 444,
"children": [
{"name": "DirtySprite", "value": 8833}
]
Expand Down Expand Up @@ -120,14 +124,18 @@
label: {
position: 'right',
verticalAlign: 'middle',
align: 'left'
align: 'left',
formatter: '{b}: {c}'
},

leaves: {
label: {
position: 'left',
verticalAlign: 'middle',
align: 'right'
position: 'left',
verticalAlign: 'middle',
align: 'right',
formatter: function (params) {
return params.data.name + params.dataIndex;
}
}
},

Expand Down

0 comments on commit 0f90a73

Please sign in to comment.