This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
Update modules to go 1.16.3 code #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the output of running `script/extract` locally on my Mac which is running `go 1.16.3`. I suspect this pulls in a few fixes/changes in how go module machinery works. I was uncertain whether to use tip of master on `go`, but thought better to use a stable version as that'd likely be more predictable.
jeffwidman
commented
Apr 28, 2021
| @@ -1,4 +1,2 @@ | |||
| github.com/hmarr/pkgextract v0.0.0-20181020214423-fb37ca687b30 h1:yv5QpAklti/aXzXutayHrR0H5q/scACFjhapn5ghONo= | |||
| github.com/hmarr/pkgextract v0.0.0-20181020214423-fb37ca687b30/go.mod h1:6iRWK5o4q/zaYE+7CCrJw+orU8YTOQk+6ceIsR/i+4c= | |||
There was a problem hiding this comment.
These two lines were the result of running go mod tidy in this directory after updating the go.mod file to go 1.16.
|
gentle nudge @thepwagner @jurre I'd like to push this across the line while it's fresh in my brain. |
|
Repeated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the output of running
script/extractlocally on my Mac whichis running
go 1.16.3.I suspect this pulls in a few fixes/changes in how go module machinery
works.
I was uncertain whether to use tip of master on
go, but thought betterto use a stable version as that'd likely be more stable/predictable for folks
comparing how the
go getmachinery works natively with how dependabot is working.Especially since some of that machinery is in heavy development due to golang/go#36460.
Better to stick with more stable code for now.
I also bumped the
go.mod/go.sumfiles in this repo togo 1.16to match...Fix #8.