patch user-level NuGet.Config before invoking dotnet/nuget tools
#8748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrs
reviewed
Jan 9, 2024
edgarrs
reviewed
Jan 9, 2024
edgarrs
reviewed
Jan 9, 2024
edgarrs
reviewed
Jan 9, 2024
bdragon
reviewed
Jan 9, 2024
brettfo
force-pushed
the
dev/brettfo/private-nuget-feeds
branch
from
c7cc03e to
f5778b5
Compare
bdragon
reviewed
Jan 10, 2024
Co-authored-by: Bryan Dragon <[email protected]>
bdragon
approved these changes
Jan 10, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dependabot is launched, private NuGet feed credentials might be passed in via the
credentialsobject. These credentials are used to query NuGet, but when the C# command line tool is launched, these credentials are not passed through. Since the command line tool may start other dotnet or NuGet processes, the proper way to propagate credentials is to patch the user-levelNuGet.Configfile located at~/.nuget/NuGet/NuGet.Config. This patching is handled in a wrapper function that ensures the original config file is restored after calling the command line tool. In production this file restore shouldn't matter, because a single dependabot run launches a new container then it's discarded, but when running locally it's best to restore this file.Fixes #8721.