Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quotes around Yarn private registry sources optional #5844

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

Nishnha
Copy link
Member

@Nishnha Nishnha commented Oct 7, 2022

Adding a yarn global or scoped registry can be done via the yarn CLI with yarn config add <key> <value>.

For some reason, yarn will remove any quotes around the value when writing to .yarnrc, so this change teaches Dependabot to parse values not encased in quotation marks.

@Nishnha Nishnha requested a review from a team as a code owner October 7, 2022 19:58
@jeffwidman jeffwidman force-pushed the yarn-private-registry-regex branch from 0e504e3 to 0850747 Compare October 10, 2022 21:13
@jeffwidman jeffwidman enabled auto-merge October 10, 2022 21:13
Adding a yarn global or scoped registry can be done via the yarn CLI
with `yarn config add <key> <value>`. For some reason, yarn will remove
any quotes around the value when writing to `.yarnrc`, so this change
teaches Dependabot to parse values not encased in quotation marks.

Co-authored-by: jakecoffman <[email protected]>
@jeffwidman jeffwidman force-pushed the yarn-private-registry-regex branch from 0850747 to 4481ff2 Compare October 10, 2022 21:16
@jeffwidman jeffwidman merged commit 620cb44 into main Oct 10, 2022
@jeffwidman jeffwidman deleted the yarn-private-registry-regex branch October 10, 2022 22:14
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants