Sanitize metadata links on all platforms #5739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in #5729, we should be using the "source" of the metadata for deciding how to sanitize, not the "place where Dependabot is hosted". This hack was annoying the folks who use GitLab to the point that [they monkey-patched this code to also run the sanitizer on GitLab](#3437 (comment)), and then contributed that back in #3437. If it's true on GitLab, it's even more true on other platforms as well for the reasons explained in #3437 (comment). So remove this guard altogether.
jeffwidman
force-pushed
the
sanitize-metadata-links-on-all-platforms
branch
from
bbdf7c7 to
9fd1c8d
Compare
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #5729, we should be using the "source" of the metadata for deciding how to sanitize, not the "place where Dependabot is hosted".
This hack was annoying the folks who use GitLab to the point that they monkey-patched this code to also run the sanitizer on GitLab, and then contributed that back in #3437.
If it's true on GitLab, it's even more true on other platforms as well for the reasons explained in #3437 (comment).
So remove this guard altogether.