-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v1/composer.lock
using composer1 update
#5717
Conversation
c1e289a
to
40bc7fb
Compare
ed0a758
to
f70b050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine! Not feel super confident when reviewing PRs for ecosystems I don't know since I don't know how stable this kind of thing is there, but I think our standard practice is to try keep everything up to date and mainly trust CI, so should be fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably fine, if tests are passing let's just roll it out and keep an eye on production metrics etc
That's the spirit guys! Nothing like a good YOLO merge! 😀 Also, I hear there's this bot that can help keep your dependencies up to date... maybe if they ever add support for bumping transitive dependencies we could try it out. 😉 |
Used `composer1 update` to update the `v1/composer.lock` file: ``` [dependabot-core-dev] ~/dependabot-core/composer/helpers/v1 $ composer1 update Loading composer repositories with package information Warning from https://repo.packagist.org: Support for Composer 1 is deprecated and some packages will not be available. You should upgrade to Composer 2. See https://blog.packagist.com/deprecating-composer-1-support/ Info from https://repo.packagist.org: #StandWithUkraine Updating dependencies (including require-dev) Nothing to install or update Package php-cs-fixer/diff is abandoned, you should avoid using it. No replacement was suggested. Writing lock file Generating autoload files 28 packages you are using are looking for funding. Use the `composer fund` command to find out more! ``` I suspect the reason that Dependabot hasn't opened PR's to bump these versions is because they're transitive dependencies. I will open a sister PR for `composer` v2, but keeping them separate in case we need to revert anything.
f70b050
to
a220495
Compare
Used
composer1 update
to update thev1/composer.lock
file:I suspect the reason that Dependabot hasn't opened PR's to bump these versions is because they're transitive dependencies.
I opened a sister PR for
composer
v2, but keeping them separate in case we need to revert anything:#5718