Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fixed error message check #4412

Merged
merged 2 commits into from
Nov 16, 2021
Merged

fix: remove fixed error message check #4412

merged 2 commits into from
Nov 16, 2021

Conversation

xlgmokha
Copy link
Contributor

@xlgmokha xlgmokha commented Nov 15, 2021

A new version of pandoc-ruby was recently released that changes the behaviour of how the pandoc executable is invoked. source. This caused one of the tests in the default branch to start failing.

The change introduced in this PR makes the minimal change necessary to fix the failing test while preserving the desired behaviour to unblock merging into the main branch.

/cc #2849

A new version of [pandoc-ruby](https://rubygems.org/gems/pandoc-ruby/versions/2.1.5) was recently released
that changes the behaviour of how the `pandoc` executable is invoked.
[src](xwmx/pandoc-ruby@2.1.4...2.1.5).

/cc #2849
@xlgmokha xlgmokha marked this pull request as ready for review November 15, 2021 21:23
@xlgmokha xlgmokha requested a review from a team as a code owner November 15, 2021 21:23
@xlgmokha
Copy link
Contributor Author

xlgmokha commented Nov 15, 2021

Re-running build because of:

     # Dependabot::SharedHelpers::HelperSubprocessFailed:
     #   Creating virtualenv meine-stadt-transparent-DpO8lN-q-py3.10 in /home/dependabot/.cache/pypoetry/virtualenvs
     #   Updating dependencies
     #   Resolving dependencies...
     #   
     #     SolverProblemError
     #   
     #     Because textract (rev 0776b86cd01fbad5b2518f75a659a1e5b614a5bd) depends on SpeechRecognition (3.7.1) which doesn't match any versions, textract is forbidden.
     #     So, because meine-stadt-transparent depends on textract (rev 0776b86cd01fbad5b2518f75a659a1e5b614a5bd), version solving failed.
     #   
     #     at /usr/local/.pyenv/versions/3.10.0/lib/python3.10/site-packages/poetry/puzzle/solver.py:241 in _solve
     #         237│             packages = result.packages
     #         238│         except OverrideNeeded as e:
     #         239│             return self.solve_in_compatibility_mode(e.overrides, use_latest=use_latest)
     #         240│         except SolveFailure as e:
     #       → 241│             raise SolverProblemError(e)
     #         242│ 
     #         243│         results = dict(
     #         244│             depth_first_search(
     #         245│                 PackageNode(self._package, packages), aggregate_package_nodes
     #   ./lib/dependabot/python/update_checker/poetry_version_resolver.rb:324:in `run_poetry_command'

Darnit Python, can't I have nice things?

@xlgmokha
Copy link
Contributor Author

Not you too Bundler. 😞

Failures:

  1) Dependabot::Bundler::UpdateChecker#latest_resolvable_version_with_no_unlock given a gem from rubygems with a version conflict at the latest version 
     Failure/Error:
       SharedHelpers.run_helper_subprocess(
         command: command,
         function: function,
         args: args,
         env: {
           # Bundler will pick the matching installed major version
           "BUNDLER_VERSION" => bundler_version,
           "BUNDLE_GEMFILE" => File.join(helpers_path, "Gemfile"),
           # Prevent the GEM_HOME from being set to a folder owned by root
           "GEM_HOME" => File.join(helpers_path, ".bundle")

     Dependabot::SharedHelpers::HelperSubprocessFailed:
       undefined method `name' for "Gemfile":String
     # /home/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:120:in `run_helper_subprocess'
     # ./lib/dependabot/bundler/native_helpers.rb:44:in `block in run_bundler_subprocess'
     # ./lib/dependabot/bundler/native_helpers.rb:40:in `run_bundler_subprocess'
     # ./lib/dependabot/bundler/update_checker/version_resolver.rb:82:in `block (2 levels) in fetch_latest_resolvable_version_details'
     # ./lib/dependabot/bundler/update_checker/shared_bundler_helpers.rb:54:in `block in in_a_native_bundler_context'
     # /home/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:48:in `block in in_a_temporary_directory'
     # /home/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:48:in `chdir'
     # /home/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:48:in `in_a_temporary_directory'
     # /home/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:37:in `in_a_temporary_repo_directory'
     # ./lib/dependabot/bundler/update_checker/shared_bundler_helpers.rb:50:in `in_a_native_bundler_context'
     # ./lib/dependabot/bundler/update_checker/version_resolver.rb:81:in `block in fetch_latest_resolvable_version_details'
     # /home/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:164:in `with_git_configured'
     # ./lib/dependabot/bundler/update_checker/version_resolver.rb:77:in `fetch_latest_resolvable_version_details'
     # ./lib/dependabot/bundler/update_checker/version_resolver.rb:43:in `latest_resolvable_version_details'
     # ./lib/dependabot/bundler/update_checker.rb:53:in `latest_resolvable_version_with_no_unlock'
     # ./spec/dependabot/bundler/update_checker_spec.rb:1451:in `block (3 levels) in <top (required)>'
     # ./spec/dependabot/bundler/update_checker_spec.rb:1466:in `block (5 levels) in <top (required)>'
     # ./spec/spec_helper.rb:54:in `block (2 levels) in <top (required)>'
     # /home/dependabot/dependabot-core/common/spec/spec_helper.rb:49:in `block (2 levels) in <top (required)>'
     # ./.bundle/ruby/2.7.0/gems/webmock-3.14.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

Finished in 6 minutes 13 seconds (files took 1.4 seconds to load)
753 examples, 1 failure, 18 pending

Failed examples:

rspec ./spec/dependabot/bundler/update_checker_spec.rb:1466 # Dependabot::Bundler::UpdateChecker#latest_resolvable_version_with_no_unlock given a gem from rubygems with a version conflict at the latest version 

@xlgmokha xlgmokha merged commit 3380365 into main Nov 16, 2021
@xlgmokha xlgmokha deleted the fix-pandoc branch November 16, 2021 00:23
@landongrindheim landongrindheim mentioned this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants