Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't freeze poetry path dependency version #2361

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Conversation

jurre
Copy link
Member

@jurre jurre commented Jul 23, 2020

This fix was proposed by @jtbeach in in #1788 and fixes #1771.

When specifying a path dependency in Poetry, we should not try to lock the version of the dependency.

@jurre jurre requested a review from feelepxyz July 23, 2020 10:52
@jurre jurre changed the title Poetry directory fix Don't freeze poetry path dependency version Jul 23, 2020
Copy link
Contributor

@feelepxyz feelepxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jurre jurre merged commit efa8ef0 into main Jul 23, 2020
@jurre jurre deleted the poetry-directory-fix branch July 23, 2020 13:45
@jtbeach
Copy link
Contributor

jtbeach commented Jul 23, 2020

Thank you so much @jurre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot incorrectly freezing Poetry path dependencies, causing schema validation failure
3 participants