production deploy #461
production deploy #461
Conversation
…dev (#399) * mvi cert and key are figaro required keys, but faked values should return nil * added initializer to load mvi cert and key
* Changed default rx sort to prescription_name * Doh. spec test heading
* EVSS: Queue requests for decision * Spec fixes
* adding secure messaging * adding spec to improve test coverage issue * stylistic improvements * refactoring prescriptions * rubocop style change * removing old rx parser * removing unused artifacts * adding new prescriptions factory
* Allow Education Forms to be sent to a different facility * PR Feedback
* swallow exception on MVI missing * remove cruft
* add authorization to SM * revert cassettes * revert cassettes * fix specs without cassettes * fix one more * rubocop * fix coverage
* send validation error to sentry * test raven capture exception
Wasn't being used by us, so remove it.
* re-enabling auth for rx * fixing stupid * DRY up MHV concerns * add in the concerns * bypass simplecov stupidness * fixing issue from code review
* Instrument sidekiq * Add sidekiq stats job spec * Cron format for stats job prevents duplicate runs * Adds notes on usage to sidekiq scheduler
* EVSS: Add an old claim reaper We don't have the ATO to store claims indefinitely, so we need to delete old ones periodically. * Update name and schedule
* updating specs for nil va_profile * va_profile return as null if mvi is down or record not found * don't need profile in user.mvi nil spec * rubocop
* add govdelivery server to app yml * use govdelivery server in staging email method * use govdelivery server in config helper * fix server name * add year to date report to scheduler * perform doesnt require argument * fix statds for spring, add govdelivery server to figaro * add govdelivery server to travis * add va stakeholders * lint * rename report mailer * rename constants
* flush specific redis namespaces via rake * minor fix * allow rake task to invoke environment for models
* EVSS: Add a new field/serializer for the list view * Add some tests * Add NotImplementedError
* Increase timeout for EVSS * Remove breakers for testing EVSS * Add some nocov to get up to coverage while breakers are disabled * Omit tracked item id if not present * Set document filename to sanitized name * Clear workers before each spec
* Removed pagination from threads * new schema for thread
* added optional draft id in creates * Added draft id to sm documentation
* allow a blank gender in User model validation * ask alastair if this is preferable * gender is more likely to be nil than blank. added specific test for it * per alastairs recommendation, put this check back in
* update va stakeholders * lint
* handle routing errors with JSONAPI * routing errors fix * commented out action_missing method, added stylistic improvements
|
Adding in the tech leads have changes in this PR to sign-off, including @ayaleloehr @austin-martinez @robbiethegeek @akainic . If everyone is OK with these changes going in, this merge is fine by me. |
|
I think this looks ok with me, would like to have @crwallace signoff since there will be things in vets-website that will be affected. |
|
I'm good with anything education related. |
|
Cool - will add @crwallace to the assignees list. |
|
If there are things in here that require updates to |
|
3ac2d12 requires vets-website |
|
pretty sure that 4e9b05a requires vets-website |
|
|
|
2d8f2f4 is the backend for SLO, session destruction and MHV audit logout but the frontend is backlogged for the moment |
|
Look good for claim status |
|
A glance at the commits looks fine from here. There will be more Facility Locator changes that @patrickvinograd is working on, but we don't have our API sources finalized yet so can't get those in until tonight or tomorrow. |
|
Thanks for the review everyone! I'll leave @crwallace and @robbiethegeek on as assignees so that we know when this can go live. |
jeffmaher
assigned robbiethegeek and unassigned robbiethegeek, akainic, ayaleloehr and austin-martinez
|
I am ok with this PR getting merged in! LGTM |
|
LGTM! |
|
In the future, let's let the DevOps team merge. If there were configuration changes required, this is the sort of thing that could break production. |
we want to start testing the daily report emails on production