Enable breakers for EVSS services (#457)

config/initializers/breakers.rb

@@ -14,11 +14,10 @@
 
 services = [
   Rx::Configuration.instance.breakers_service,
-  SM::Configuration.instance.breakers_service
-  # TODO: (AJM) Disabled for testing, add these back in for launch
-  # EVSS::ClaimsService.breakers_service,
-  # EVSS::CommonService.breakers_service,
-  # EVSS::DocumentsService.breakers_service
+  SM::Configuration.instance.breakers_service,
+  EVSS::ClaimsService.breakers_service,
+  EVSS::CommonService.breakers_service,
+  EVSS::DocumentsService.breakers_service
 ]
 
 plugin = Breakers::StatsdPlugin.new

lib/evss/base_service.rb

@@ -10,7 +10,6 @@ def initialize(headers)
       @headers = headers
     end
 
-    # :nocov:
     def self.create_breakers_service(name:, url:)
       path = URI.parse(url).path
       host = URI.parse(url).host
@@ -23,7 +22,6 @@ def self.create_breakers_service(name:, url:)
         request_matcher: matcher
       )
     end
-    # :nocov:
 
     protected
 

lib/evss/common_service.rb

@@ -10,7 +10,6 @@ def find_rating_info(participant_id)
            { participantId: participant_id }.to_json
     end
 
-    # :nocov:
     # TODO: (AJM) Add spec to cover this
     def create_user_account
       post 'persistentPropertiesService/11.0/createUserAccount'
@@ -19,6 +18,5 @@ def create_user_account
     def self.breakers_service
       BaseService.create_breakers_service(name: 'EVSS/Common', url: BASE_URL)
     end
-    # :nocov:
   end
 end

spec/lib/evss/base_service_spec.rb

@@ -2,8 +2,6 @@
 require 'rails_helper'
 require 'evss/claims_service'
 
-# :nocov:
-# TODO: (AJM) Add these back when breakers is turned back on
 describe EVSS::BaseService do
   context 'with an outage' do
     let(:service) { EVSS::ClaimsService.new({}) }
@@ -12,13 +10,12 @@
       EVSS::ClaimsService.breakers_service.begin_forced_outage!
     end
 
-    xit 'raises an error on get' do
+    it 'raises an error on get' do
       expect { service.all_claims }.to raise_exception(Breakers::OutageException)
     end
 
-    xit 'raises an error on post' do
+    it 'raises an error on post' do
       expect { service.find_claim_by_id(123) }.to raise_exception(Breakers::OutageException)
     end
   end
 end
-# :nocov:

spec/services/disability_claim_service_spec.rb

@@ -55,28 +55,25 @@
     end
   end
 
-  # TODO: (AJM) add these tests back when turning breakers back on (post testing)
-  # :nocov:
   context 'when EVSS client has an outage' do
     describe '#all' do
-      xit 'returns all claims for the user' do
+      it 'returns all claims for the user' do
         EVSS::ClaimsService.breakers_service.begin_forced_outage!
         claim = FactoryGirl.create(:disability_claim, user_uuid: user.uuid)
-        claims = subject.all
+        claims, synchronized = subject.all
         expect(claims).to eq([claim])
-        expect(claims.first.successful_sync).to eq(false)
+        expect(synchronized).to eq(false)
       end
     end
 
     describe '#update_from_remote' do
-      xit 'returns claim' do
+      it 'returns claim' do
         EVSS::ClaimsService.breakers_service.begin_forced_outage!
         claim = FactoryGirl.build(:disability_claim, user_uuid: user.uuid)
-        updated_claim = subject.update_from_remote(claim)
+        updated_claim, synchronized = subject.update_from_remote(claim)
         expect(updated_claim).to eq(claim)
-        expect(updated_claim.successful_sync).to eq(false)
+        expect(synchronized).to eq(false)
       end
     end
-    # :nocov:
   end
 end