fix: memory-limit option for phpstan #4900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might only be a problem for newer phpstan versions (2.1.1 here). If you try to run `phpstan` the way ale will when it builds the option, you will get something like: ``` The "--memory-limit" option requires a value. ``` It wants you to use `--memory-limit=-1` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might only be a problem for newer phpstan versions (2.1.1 here).
If you try to run
phpstanthe way ale will when it builds the option, you will get something like:It wants you to use
--memory-limit=-1instead.Updated existing test, but we should probably check to make sure phpstan is
backwardsforward compatible with this--key=valoption format if this is in fact a change to how that option is parsed, and otherwise make some kind of shim for both version?