Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove importsNotUsedAsValues #240

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Releases of the extension can be downloaded from [Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=denoland.vscode-deno).

### [v2.3.2](https://github.com/denoland/vscode_deno/compare/v2.3.1...v2.3.2) / 2020.10.12

- chore: disable importsNotUsedAsValues --unstable default (#240)
- build: husky pre-commit hooks (#224)

### [v2.3.1](https://github.com/denoland/vscode_deno/compare/v2.3.0...v2.3.1) / 2020.09.24

- fix: enable recursive mode for mkdir of cache path (#232)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "vscode-deno",
"displayName": "Deno",
"description": "Deno support for VSCode",
"version": "2.3.1",
"version": "2.3.2",
"publisher": "denoland",
"icon": "deno.png",
"galleryBanner": {
Expand Down
3 changes: 0 additions & 3 deletions typescript-deno-plugin/src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,6 @@ export class DenoPlugin implements typescript.server.PluginModule {

const extraOptions: ts.CompilerOptions = {
isolatedModules: this.configurationManager.config.unstable,
importsNotUsedAsValues: this.configurationManager.config.unstable
? this.ts.ImportsNotUsedAsValues.Error
: this.ts.ImportsNotUsedAsValues.Remove,
};

const compilationSettings = merge(
Expand Down