feat(std/node): Added implementation of os.homedir() #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kt3k
reviewed
Apr 27, 2021
node/os.ts
Outdated
| notImplemented(SEE_GITHUB_ISSUE); | ||
| switch (Deno.build.os) { | ||
| case "windows": | ||
| return Deno.env.get("HOMEPATH") || null; |
There was a problem hiding this comment.
I think 'USERPROFILE' is more reliable env var for pointing the home directory in windows. See this discussion for example denoland/deno#3462
Node.js documentation also says it uses 'USERPROFILE' https://nodejs.org/api/os.html#os_os_homedir
|
@kt3k Thank you for your review. I updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the implementation of
os.homedir()was lack.This is related to https://github.com/denoland/deno/issues/3802