Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front-matter): handle empty frontMatter data #6481

Merged

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Mar 15, 2025

fixes #6464

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (2395035) to head (51fea13).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6481   +/-   ##
=======================================
  Coverage   95.29%   95.30%           
=======================================
  Files         575      576    +1     
  Lines       43279    43313   +34     
  Branches     6467     6480   +13     
=======================================
+ Hits        41243    41278   +35     
+ Misses       1995     1994    -1     
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen marked this pull request as draft March 15, 2025 12:30
@timreichen timreichen marked this pull request as ready for review March 17, 2025 08:26
@kt3k
Copy link
Member

kt3k commented Mar 24, 2025

related #6393

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 7e4a9a3 into denoland:main Mar 24, 2025
18 checks passed
@timreichen timreichen deleted the front_matter-fix-handle-empty-frontMatter-data branch March 24, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontmatter test fails when the front matter is empty
2 participants