Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(front-matter): remove double tests in any_test.ts #6474

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Mar 12, 2025

This PR removes tests in front-matter/any_test.ts that are already covered by front-matter/json_test.ts, front-matter/toml_test.ts and front-matter/yaml_test.ts.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (75ecea0) to head (2cd22ba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6474      +/-   ##
==========================================
- Coverage   95.68%   95.68%   -0.01%     
==========================================
  Files         575      575              
  Lines       43192    43192              
  Branches     6475     6475              
==========================================
- Hits        41328    41327       -1     
- Misses       1825     1826       +1     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen marked this pull request as draft March 12, 2025 07:49
@timreichen timreichen changed the title refactor(front-matter): remove any tests refactor(front-matter): remove double tests in any_test.ts Mar 12, 2025
@timreichen timreichen marked this pull request as ready for review March 12, 2025 22:07
@kt3k kt3k changed the title refactor(front-matter): remove double tests in any_test.ts test(front-matter): remove double tests in any_test.ts Mar 13, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit d78884e into denoland:main Mar 13, 2025
22 checks passed
@timreichen timreichen deleted the front-matter-remove-any-tests branch March 13, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants