Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(async): use FakeTime in pooledMap testing #6468

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 7, 2025

closes #6287

@kt3k kt3k requested a review from satyarohith March 7, 2025 09:05
@github-actions github-actions bot added the async label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (1dee498) to head (8a6fee1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6468   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files         576      576           
  Lines       43053    43053           
  Branches     6450     6450           
=======================================
+ Hits        41194    41195    +1     
+ Misses       1820     1819    -1     
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit b2a987a into denoland:main Mar 10, 2025
18 checks passed
@kt3k kt3k deleted the fix-flaky-pool-test branch March 10, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: flaky test pooledMap() under async/pool_test.ts failing on canary, macOS-latest
2 participants