Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs/unstable): fix node.js test runner, fix readTextFile and copyFile in Node.js #6441

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

0f-0b
Copy link
Contributor

@0f-0b 0f-0b commented Feb 22, 2025

This PR changes the Node.js test runner to import the correct modules and fixes the new test failures.

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.98%. Comparing base (71c828a) to head (99967fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_read_text_file.ts 14.28% 6 Missing ⚠️
fs/unstable_copy_file.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6441      +/-   ##
==========================================
- Coverage   95.98%   95.98%   -0.01%     
==========================================
  Files         564      564              
  Lines       42482    42481       -1     
  Branches     6394     6394              
==========================================
- Hits        40775    40774       -1     
  Misses       1668     1668              
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @0f-0b

LGTM

@kt3k kt3k changed the title chore: fix node.js test runner fix(fs/unstable): fix node.js test runner, fix readTextFile and copyFile in Node.js Feb 25, 2025
@kt3k kt3k merged commit f53efe1 into denoland:main Feb 25, 2025
19 checks passed
@0f-0b 0f-0b deleted the fix-node-test-runner branch February 25, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants