fix (crypto) Remove fixed version imports #1135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes two absolute version imports within the crypto bench, as std should always depend on sibling modules (and be sibling-compatible).
There is another fixed dependency within
node/_tools
onx/compress
- this also seems a bit odd but harder to fix without some discussion.We had a short discussion on Discord about adding a CI step that checks if
std
does not contain any external dependencies. There are ways to do this with the current (unstable)deno info
JSON output, but that might be another discussion altogether, as running / testing a deno module while allowing only local imports might be a more generally useful case.