feat: update v8 flags #707
Conversation
core/runtime/setup.rs
Outdated
| " --harmony-temporal", | ||
| " --js-explicit-resource-management", |
There was a problem hiding this comment.
Oh nice, last time I checked (last week) it still wasn't supported. Is it just partial support?
There was a problem hiding this comment.
Maybe. It appears that test262 is still insufficient and I'm not sure how widely it has been covered.
There was a problem hiding this comment.
V8 12.4 can parse using declarations but does not actually dispose the resources. The functionality was first added in V8 12.5.79.
SuppressedError() crashes the process.
There was a problem hiding this comment.
Thanks for the info! I've removed this flag.
| @@ -23,13 +23,11 @@ fn v8_init( | |||
|
|
|||
| let base_flags = concat!( | |||
| " --wasm-test-streaming", | |||
| " --harmony-import-assertions", | |||
There was a problem hiding this comment.
I'm not sure if we should disable this one now - it will start crashing on assert keyword. Or do you plan to conditionally enable it in Deno?
There was a problem hiding this comment.
The assert keyword is also enabled by default, so this change has no effect.
https://github.com/v8/v8/blob/12.4.254.12/src/flags/flag-definitions.h#L295
I plan to conditionally disable it in Deno. It seems that it is probably enabled if both --harmony-import-assertions and --no-harmony-import-assertions are specified.
petamoriken
force-pushed
the
update/v8-flags
branch
from
0de111e to
7f121c3
Compare
|
It failed to install |
related: denoland/deno#17944 (comment), denoland/deno#23450
Removed flags enabled by default and added flags for
Explicit Resource Managementand Float16Array.