Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op2): fake async, fix raw fields for WebIDL converter, add more implementations for ToV8 and FromV8 #1065

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jan 29, 2025

No description provided.

@crowlKats crowlKats marked this pull request as draft January 29, 2025 17:50
@crowlKats crowlKats changed the title [WIP] fake async feat(op2): fake async Jan 30, 2025
# Conflicts:
#	core/cppgc.rs
@crowlKats crowlKats changed the title feat(op2): fake async feat(op2): fake async, fix raw fields for WebIDL converter, add more implementations for ToV8 and FromV8 Jan 30, 2025
@crowlKats crowlKats marked this pull request as ready for review January 30, 2025 06:48
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 46.03175% with 68 lines in your changes missing coverage. Please review.

Project coverage is 81.46%. Comparing base (0c7f83e) to head (69792fe).
Report is 249 commits behind head on main.

Files with missing lines Patch % Lines
core/convert.rs 0.00% 56 Missing ⚠️
ops/op2/mod.rs 53.84% 6 Missing ⚠️
testing/checkin/runner/ops_async.rs 25.00% 3 Missing ⚠️
ops/op2/dispatch_async.rs 71.42% 2 Missing ⚠️
ops/op2/signature.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
+ Coverage   81.43%   81.46%   +0.02%     
==========================================
  Files          97      101       +4     
  Lines       23877    27951    +4074     
==========================================
+ Hits        19445    22769    +3324     
- Misses       4432     5182     +750     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 55ed62a into denoland:main Jan 30, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants