Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch: proper error for unsupported protocol #4085

Merged
merged 1 commit into from
Feb 23, 2020
Merged

fetch: proper error for unsupported protocol #4085

merged 1 commit into from
Feb 23, 2020

Conversation

kevinkassimo
Copy link
Contributor

Related to #4038

Don't panic. Throw a proper error when fetching a protocol not support/not yet supported

@ecyrbe
Copy link
Contributor

ecyrbe commented Feb 23, 2020

hi, the discussion on the issue seems to orient the solution to allow it but trigger proper allow-read on the directory.
am i reading it wrong ?

@kevinkassimo
Copy link
Contributor Author

@ecyrbe they are 2 separate problems. That’s why this PR does not intend to close that issue.

We also had another discussion about fetch local before: #2150

bartlomieju
bartlomieju approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit e9fff02 into denoland:master Feb 23, 2020
@bartlomieju bartlomieju mentioned this pull request Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinkassimo @ecyrbe @bartlomieju