Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing node os.platform() implementation #4064

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Add missing node os.platform() implementation #4064

merged 1 commit into from
Feb 21, 2020

Conversation

ecyrbe
Copy link
Contributor

@ecyrbe ecyrbe commented Feb 21, 2020

PR for one of the tasks from issue #3802 . Adding platform support as it's now there on process impl .

ps: planning to make more of thoses as i learn deno a little more before starting more serious contributions.

@claassistantio
Copy link

claassistantio commented Feb 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ecyrbe ecyrbe changed the title feat(os) : add platform impl Add missing os.platform() implementation Feb 21, 2020
@ecyrbe ecyrbe requested review from bartlomieju and ry and removed request for ry February 21, 2020 16:20
@ecyrbe ecyrbe changed the title Add missing os.platform() implementation Add missing node os.platform() implementation Feb 21, 2020
ry
ry approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 754b8c6 into denoland:master Feb 21, 2020
@ecyrbe ecyrbe deleted the feature/add-os-platform branch February 22, 2020 00:16
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@ecyrbe
feat(std/node) : add os.platform (denoland/deno#4064)
2cc6757
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ecyrbe
feat(node) : add os.platform (denoland/deno#4064)
2f7c849
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ecyrbe @caspervonb
feat(node) : add os.platform (denoland/deno#4064)
a5716f5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@ecyrbe @caspervonb
feat(node) : add os.platform (denoland/deno#4064)
717cbb3
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ecyrbe @caspervonb
feat(node) : add os.platform (denoland/deno#4064)
38f4349
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ecyrbe @caspervonb
feat(node) : add os.platform (denoland/deno#4064)
85f4710
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ecyrbe @caspervonb
feat(node) : add os.platform (denoland/deno#4064)
f7cadfa
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@ecyrbe @denobot
feat(node) : add os.platform (denoland/deno#4064)
71ff289
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@ecyrbe @denobot
feat(node) : add os.platform (denoland/deno#4064)
2451d2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecyrbe @claassistantio @ry