fix: createSecKey logic #4063
Merged
fix: createSecKey logic #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ah cool thanks. Could you add a test with the expected output in a corner case? Maybe using the —seed flag? It's very helpful for us to nail down these cases in the tests. |
|
Sure, I will do it. 😄 |
|
You can reproduce the error when you run only the file with cargo run -- --seed=86 -A testing/runner.ts --exclude "**/testdata" ws/mod_test.tsCould you review it? |
|
@ry Thank you very much for cleaning up! 🙏 |
|
Thanks! |
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Feb 26, 2020
* tag 'dm': (58 commits) Port permission_prompt_tests to Rust (denoland#4129) upgrade: TypeScript 3.8 (denoland#4100) Remove _async from method names since _sync are gone (denoland#4128) ci: Use fetch-depth: 5 (denoland#4127) fix: Resolve makeTemp* paths from CWD (denoland#4104) Clean up how we use opIds (denoland#4118) Fix issues with JavaScript importing JavaScript. (denoland#4120) fix: [http] Consume unread body and trailers before reading next request (denoland#3990) Remove ansi_term dependency (denoland#4116) port tools/repl_test.py to Rust (denoland#4096) Revert "Remove ansi_term dependency" fix: createSecKey logic (denoland#4063) Add Deno.Err change missing from previous commit (denoland#4113) rename Deno.Err -> Deno.errors (denoland#4093) doc: Remove old link to deno types output (denoland#4111) feat: Add Deno.formatDiagnostics (denoland#4032) disable std/examples/chat tests for windows (denoland#4109) update build instructions for windows (denoland#4027) Remove ansi_term dependency (denoland#4106) fix: add mutex guard for permission_prompt tests (denoland#4105) ...
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found a tiny issue.
It sometimes includes
undefinedbecause ofMath.round, likecqF-vcjundefinedqZxmomrJ.