Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --no-prompt flag #3183

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Remove --no-prompt flag #3183

merged 2 commits into from
Oct 22, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Oct 22, 2019

This PR removes --no-prompt flag and the feature of prompting the required permissions on demand.

Partially addresses #2767.

@kt3k kt3k force-pushed the feature/no-no-prompt branch from 4371433 to f5004d1 Compare October 22, 2019 10:10
ry
ry approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - going to just land this before anyone complains : )

I think this the right direction.

@ry ry merged commit 2804ba8 into denoland:master Oct 22, 2019
@kt3k kt3k deleted the feature/no-no-prompt branch October 23, 2019 02:41
@kt3k kt3k mentioned this pull request Oct 23, 2019
Closed
@ry ry mentioned this pull request Oct 29, 2019
Merged
@bartlomieju bartlomieju mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @ry