Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): descriptive sqlite error messages #28272

Merged
merged 2 commits into from
Feb 24, 2025
Merged

fix(ext/node): descriptive sqlite error messages #28272

merged 2 commits into from
Feb 24, 2025

Conversation

littledivy
Copy link
Member

Fixes #28259

bartlomieju
bartlomieju approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marvinhagemeister
marvinhagemeister approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 7fa8fc4 into denoland:main Feb 24, 2025
18 checks passed
littledivy added a commit that referenced this pull request Feb 25, 2025
@littledivy
fix(ext/node): descriptive sqlite error messages (#28272)
1fe76c7 
Fixes #28259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:sqlite does not surface a descriptive error message when a prepared statement fails
3 participants
@littledivy @marvinhagemeister @bartlomieju