Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): DatabaseSync#exec should execute batch statements #28053

Merged
merged 2 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ext/node/ops/sqlite/database.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,7 @@ impl DatabaseSync {
let db = self.conn.borrow();
let db = db.as_ref().ok_or(SqliteError::InUse)?;

let mut stmt = db.prepare_cached(sql)?;
stmt.raw_execute()?;
db.execute_batch(sql)?;

Ok(())
}
Expand Down
13 changes: 13 additions & 0 deletions tests/unit_node/sqlite_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,3 +184,16 @@ Deno.test("[node/sqlite] applyChangeset across databases", () => {
{ key: 2, value: "world", __proto__: null },
]);
});

Deno.test("[node/sqlite] exec should execute batch statements", () => {
const db = new DatabaseSync(":memory:");
db.exec(`CREATE TABLE one(id int PRIMARY KEY) STRICT;
CREATE TABLE two(id int PRIMARY KEY) STRICT;`);

const table = db.prepare(
`SELECT name FROM sqlite_master WHERE type='table'`,
).all();
assertEquals(table.length, 2);

db.close();
});