Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): handle non-ws upgrade headers #27931

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

littledivy
Copy link
Member

Fixes #27091

Don't perform a WS upgrade on non-ws upgrades by checking the value.

Don't perform a WS upgrade on non-ws upgrades by checking the value.
@littledivy littledivy changed the title fix(ext/http): handle non-ws upgrade headers fix(ext/node): handle non-ws upgrade headers Feb 2, 2025
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@littledivy littledivy merged commit 441b1d3 into denoland:main Feb 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: expected i32
3 participants