fix(ext/node): implement SQLite Session API #27909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Feb 3, 2025
| @@ -73,6 +73,27 @@ Deno.test("[node/sqlite] StatementSync read bigints are supported", () => { | |||
| assertEquals(stmt.get(), { key: 1n, __proto__: null }); | |||
| }); | |||
|
|
|||
| Deno.test("[node/sqlite] createSession and changesets", () => { | |||
There was a problem hiding this comment.
Do we have to create these from scratch? Can't we use tests from Node's suite?
There was a problem hiding this comment.
Yep we should also enable the Node.js tests.
There was a problem hiding this comment.
I guess not right now because the sqlite API is not fully on par with Node.js for the tests to pass.
Signed-off-by: Divy Srivastava <[email protected]>
bartlomieju
approved these changes
Feb 4, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/api/sqlite.html#class-session